================
@@ -161,6 +161,7 @@ bool CoreEngine::ExecuteWorkList(const StackFrame *SF, 
unsigned MaxSteps,
     return MaxSteps - Steps;
   };
   const unsigned STUSteps = ProcessWList(MaxSteps);
+  STUHadWorkRemaining = WList->hasWork();
----------------
NagyDonat wrote:

> I'm not a huge fan of that: if we finish the CTU work we may end up doing STU 
> work using the CTU budget; this could complicate a lot of things and may not 
> be very intuitive: imagine extending finding that extending the CTU budget 
> results in a larger STU exploration, wouldn't it be strange?

> The problem I see is that in non-CTU mode we would not set the flag, and it 
> may not be obvious from users that don't know about this detail; they may 
> assume that it is always set.

These are both good points, I'm leaning towards keeping the current state of 
the PR.

https://github.com/llvm/llvm-project/pull/219225
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to