================
@@ -90,16 +101,43 @@ using EntityPointerLevelSet =
///
/// \param E the pointer expression to be translated
/// \param Ctx the AST context of `E`
-/// \param AddEntity the callback provided by the caller to convert EntityNames
-/// to EntityIds.
+/// \param Extractor the TUSummaryExtractor used to convert NamedDecls to
+/// EntityIds.
llvm::Expected<EntityPointerLevelSet>
translateEntityPointerLevel(const Expr *E, ASTContext &Ctx,
TUSummaryExtractor &Extractor);
+/// Same as `translateEntityPointerLevel`, except it returns raw
+/// `(NamedDecl *, pointer level, is-return)` tuples (a.k.a. DeclPointerLevels)
+/// instead of assembling an `EntityPointerLevelSet` directly.
+llvm::Expected<DeclPointerLevels>
+translateDeclPointerLevel(const Expr *E, ASTContext &Ctx,
+ TUSummaryExtractor &Extractor);
+
+/// Assemble `(NamedDecl *, pointer level, is-return)` tuples (a.k.a.
+/// DeclPointerLevels) to `EntityPointerLevelSet`.
+Expected<EntityPointerLevelSet>
+toEntityPointerLevels(const DeclPointerLevels &DPLs, ASTContext &Ctx,
+ TUSummaryExtractor &Extractor);
+
+/// Convert a single `(NamedDecl *, pointer level, is-return)` tuple (a.k.a.
+/// DeclPointerLevel) to an `EntityPointerLevel`.
----------------
steakhal wrote:
I think you have explained the DeclPointerLevel tuple at least 2 times before
this. I think you can simplify this to just spelling `DeclPointerLevel`
anywhere here.
https://github.com/llvm/llvm-project/pull/218196
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
