yairbenavraham wrote:

> Thank you!
> 
> Kind request - move "constrained" tests to -constrained.c

Do I need to create one? E.g.  
./clang/test/CodeGen/AArch64/neon/**fma-sqrt-constrained.c**?

> > Do I need to create one? E.g. 
> > ./clang/test/CodeGen/AArch64/neon/fma-sqrt-constrained.c?
> 
> Note quite.
> 
>     * Since regular 
> [vsqrtq_f64](https://developer.arm.com/architectures/instruction-sets/intrinsics/vsqrtq_f64)
>  is located in `./clang/test/CodeGen/AArch64/neon/intrinsics.c`, the 
> constrained version should be located in 
> `/clang/test/CodeGen/AArch64/neon/intrinsics-constrained.c`
> 
>     * Since regular `vfma_f64` is in 
> `clang/test/CodeGen/AArch64/neon/fused-multiply.c`, the constrained version 
> should go to `clang/test/CodeGen/AArch64/neon/fused-multiply-constrained.c`.
> 
> 
> Hopefully this makes sense.

Just out of curiosity, is there any plan to make the *-constrained.c naming 
convention meaningful to lit? For example, by extending clang/test/lit.cfg.py 
or the AArch64 lit.local.cfg so that intrinsics-constrained.c is associated 
with intrinsics.c?

https://github.com/llvm/llvm-project/pull/218307
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to