llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) <details> <summary>Changes</summary> We can just check `isBooleanType()` instead. --- Full diff: https://github.com/llvm/llvm-project/pull/219943.diff 1 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+4-4) ``````````diff diff --git a/clang/lib/AST/ByteCode/Compiler.cpp b/clang/lib/AST/ByteCode/Compiler.cpp index a65a0441bba62..55abd51659b46 100644 --- a/clang/lib/AST/ByteCode/Compiler.cpp +++ b/clang/lib/AST/ByteCode/Compiler.cpp @@ -1551,7 +1551,6 @@ bool Compiler<Emitter>::VisitLogicalBinOp(const BinaryOperator *E) { BinaryOperatorKind Op = E->getOpcode(); const Expr *LHS = E->getLHS(); const Expr *RHS = E->getRHS(); - OptPrimType T = classify(E->getType()); if (Op == BO_LOr) { // Logical OR. Visit LHS and only evaluate RHS if LHS was FALSE. @@ -1600,9 +1599,10 @@ bool Compiler<Emitter>::VisitLogicalBinOp(const BinaryOperator *E) { return this->emitPopBool(E); // For C, cast back to integer type. - assert(T); - if (T != PT_Bool) - return this->emitCast(PT_Bool, *T, E); + if (!E->getType()->isBooleanType()) { + PrimType T = classifyPrim(E->getType()); + return this->emitCast(PT_Bool, T, E); + } return true; } `````````` </details> https://github.com/llvm/llvm-project/pull/219943 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
