vgvassilev wrote: > Had to revert the latest commit for now !! > > I totally missed that some direct `ExecuteAction()` clients, particularly > `clang-scan-deps`, intentionally carry`-mllvm ` options without registering > the corresponding backend flags. Moving the parsing into the common path > caused those tools to reject otherwise valid options, so the narrower > Clang-Repl-specific handling is safer ! > > See CI for errors. It shows > > ``` > Unknown command line argument '-stackmap-version=2' > Unknown command line argument '-x86-asm-syntax=intel' > Unknown command line argument '-enable-memcpyopt-without-libcalls' > ```
If we go that way I believe this changes don’t need to be reviewed by @AaronBallman anymore. Let’s give him a day or two and we can rely on post-merge review if necessary… https://github.com/llvm/llvm-project/pull/197133 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
