================
@@ -8684,6 +8690,13 @@ class Parser : public CodeCompletionHandler {
     return isCXXTypeId(Context, isAmbiguous);
   }
 
+  bool isNextCXXTypeId(TentativeCXXTypeIdContext Context, bool &IsAmbiguous);
+
+  bool isNextCXXTypeId(TentativeCXXTypeIdContext Context) {
----------------
AaronBallman wrote:

These should come with comments explaining what they do; because we have 
`isCXXTypeId` already and it's documented as:

> Determine whether the next set of tokens contains a type-id.

which sounds like it does exactly the same thing here. Actually, given that we 
only ever call this one time, I think it might make more sense to inline it in 
the call site rather than add two functions to `Parser`. This could be handled 
via an immediately invoked lambda, so we don't even need to worry about a name.

https://github.com/llvm/llvm-project/pull/210353
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to