https://github.com/zygoloid approved this pull request.

Really nice! Very happy to see my rST table generator getting deleted :) I 
think the markdown output is much less readable, but I don't believe anyone is 
reading it anyway, so that's not really a loss.

I did a spot check and mostly the output seems to be identical to the old 
output, except in cases like `-Wc++11-narrowing` 
([before](https://llvmdocs.staging.reidkleckner.dev/before/clang/docs/DiagnosticsReference.html#wc-11-narrowing),
 
[after](https://llvmdocs.staging.reidkleckner.dev/after/clang/docs/DiagnosticsReference.html#wc-11-narrowing))
 where this fixes a bug. (There are a bunch more instances of this, all 
similar: the rST output was incorrectly centering things that should have been 
left-aligned when a table cell contains a placeholder.) The rendering of 
`-Wframe-larger-than`'s description is also improved here.

https://github.com/llvm/llvm-project/pull/221361
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to