================ @@ -1262,50 +1262,28 @@ static RValue emitLibCallForAtomicExpr(CIRGenFunction &cgf, AtomicExpr *e, case AtomicExpr::AO__atomic_store: case AtomicExpr::AO__atomic_store_n: case AtomicExpr::AO__c11_atomic_store: + case AtomicExpr::AO__hip_atomic_store: ---------------- Lancern wrote:
Yeah I'm planning to cover OpenCL and HIP support in later patches, but I was assuming removing those variants from NYI could be fine for now since your previous patch (for atomic exchange) includes OpenCL and HIP variants. Should I keep OpenCL and HIP variants NYI for now? They are NYI in later code anyway. https://github.com/llvm/llvm-project/pull/223732 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
