uweigand wrote:

> One solution would be to add a zext attribute to the boolean arg with 
> CreateCall(), and maybe that is preferred, but there are however many cases 
> of this, so if this could be considered an internal function (and detected in 
> the backend check as such), there would be no need. If tysan.cpp is 
> guaranteed to be compiled with clang, I think it is safe to ignore this, as 
> long as we don't rely on those extention attributes ourselves. I think this 
> is the case after the move of compiler-rt from ENABLE_PROJECTS to 
> ENABLE_RUNTIMES, but I am not sure that it is not possible to use another 
> build configuration.

Even if tysan.cpp is compiled with clang, the compiler will still assume that 
any caller complies with the platform ABI and therefore may assume the incoming 
argument was extended.  I do think we need to change the caller(s) to ensure 
proper extension here.


https://github.com/llvm/llvm-project/pull/223755
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to