https://github.com/rnk approved this pull request.

Looks good to me, but for bonus points, I think we can include all of these 
"forward declared" APIs in compiler-rt/include/profile/instr_prof_interface.h, 
which appears to have been added in 2024, so it might post-date these docs.

In that change, you can clean up the docs to point to the interface header, and 
briefly mention that all APIs can be forward declared if including compiler 
interface headers is challenging in a build environment.

https://github.com/llvm/llvm-project/pull/224424
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to