martell requested review of this revision. martell added a comment. Thanks for the review @rnk . I addressed the comment nit you had. @mstorsjo I updated this to also handle thumb on arm.
When doing that I noticed there is something really strange about the existing macro defines. I assume they should only be defined when exceptions is enabled. This is by default in c++ mode of with -fexceptions in c mode. I moved the defines within a check of exceptions being enabled to address that. Apple seem to do their own thing for watchOS by just force enabling it for that target only. Some input there would help a lot. Also if you think we should define the macros even when exceptions are disabled could you explain why? Repository: rL LLVM https://reviews.llvm.org/D39673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
