================ @@ -0,0 +1,541 @@ +//===-- UnsafeSymlinkTestChecker.cpp ------------------------------*- C++ -*--// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// +// +// Defines a checker that checks for unsafe symlink detection. This checks for +// 2 related conditions: +// - File status is read and used to detect symlink before the file is opened. +// The file can be changed asynchronously between reading the status data and +// opening the file, so this check is not safe to use. +// - To fix the previous issue, the file status can be read after the open too +// and compared to the previous value. If it did not change, the symlink +// status is safely determined (the file can not be changed externally after +// it was opened). The checker can detect a missing comparison of the "before" +// and "after" status values. +// (In all cases use of the O_NOFOLLOW flag at 'open' prevents the warning.) +// +//===----------------------------------------------------------------------===// + +#include "clang/AST/StmtVisitor.h" +#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" +#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" +#include "clang/StaticAnalyzer/Core/Checker.h" +#include "clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h" +#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" +#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" +#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerHelpers.h" +#include <optional> + +using namespace clang; +using namespace ento; + +namespace { + +/// Used to identify a file name. +/// If created with a symbolic region, use the region as key. +/// If created with a string region, use the contained string as key (different +/// string regions with same content should be equal). +struct FileNameKey { + std::string FileNameStr; + const MemRegion *Region = nullptr; ---------------- balazske wrote:
The `variant` looks not better as the current solution, for example the `Profile` is more difficult with it. This struct is used only as a key in the map and the constructor can ensure that the fields are set correctly. https://github.com/llvm/llvm-project/pull/221184 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
