================
@@ -224,19 +190,22 @@ int main(int argc, const char **argv) {
[Mangler = std::move(Mangler),
ContextProvider = std::move(ContextProvider)](
const std::vector<std::string> &Args, llvm::StringRef File) {
- // Issue: If File is relative, it's relative to the compile
+ // FIXME: If File is relative, it's relative to the compile
// command's "directory", not our CWD, but ToolExecutor doesn't
// expose "directory" here, so make_absolute can resolve it wrong
// and miss the .clangd file. See
// indexer-clangd-config-relative-path.test.
llvm::SmallString<256> AbsFile(File);
----------------
HighCommander4 wrote:
We're not using `AbsFile` any more, it can be removed.
Please also update the comment above to not talk about make_absolute, and
instead say we don't apply the config for relative paths because we don't have
enough information here to correctly determine the absolute path.
https://github.com/llvm/llvm-project/pull/214951
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
