aaron.ballman added a comment. In https://reviews.llvm.org/D40242#931173, @ogoffart wrote:
> > You should add a test case that demonstrates code which would otherwise > > trigger an analysis-based warning but doesn't due to disabling all warnings. > > No warnings are triggered. Because the diagnostic engine ignores them. > This just optimize the code so no analysis are preformed when no warning can > be triggered. Correct -- I'm asking for a test that ensures we don't regress the intended behavior of this patch by accident at some point (behavioral changes should always have at least one accompanying test). https://reviews.llvm.org/D40242 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
