martell added a comment. In https://reviews.llvm.org/D40285#931248, @mstorsjo wrote:
> I'm a little divided - either we remove both WIN32 and WIN64 from all mingw > configurations, or we add the missing WIN32 for x86_64 mingw. Removing would > be the strictly correct thing to do, but I'm sure it will break code that > used to work before (even though it's wrong to rely on the unprefixed one). looking at different `windef.h` I see - specifically ReactOS #ifndef WIN32 #define WIN32 #endif I don't have MSVC off hand to check if it is there but I do remember MSVC projects used to pass `/D "WIN32"` so having them might make sense also. I'm going to try include them and fold all the code for the different arch's for mingw in a moment Repository: rL LLVM https://reviews.llvm.org/D40285 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
