llvmorg-github-actions[bot] wrote:

<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: gallopruss-sie

<details>
<summary>Changes</summary>

These tests check that, with no GCC installation, the driver finds the linker, 
crt0 and sysroot relative to its own bin/ directory. The compiler-rt paths come 
from the resource directory, which the tests did not specify, so they relied on 
the build's CLANG_RESOURCE_DIR placing it within the fake toolchain tree.

With a relative CLANG_RESOURCE_DIR containing several "..", e.g. 
../../../../lib/clang/24 as used by Gentoo, the resource directory resolves 
outside of the test tree. This previously passed only because the unnormalized 
path still contained "riscv64-nogcc/". Since 99988429d395 removed the dots from 
the path, the checks fail.

Pass an explicit -resource-dir within the test tree so the tests don't depend 
on the build configuration.

---
Full diff: https://github.com/llvm/llvm-project/pull/226952.diff


2 Files Affected:

- (modified) clang/test/Driver/riscv32-toolchain-extra.c (+2) 
- (modified) clang/test/Driver/riscv64-toolchain-extra.c (+2) 


``````````diff
The server is unavailable at this time. Please wait a few minutes before you 
try again.
``````````

</details>


https://github.com/llvm/llvm-project/pull/226952
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to