================
@@ -764,11 +986,13 @@ bool createParameters(NewFunction &ExtractedFunc,
return false;
// Parameter qualifiers are same as the Decl's qualifiers.
QualType TypeInfo = VD->getType().getNonReferenceType();
- // FIXME: Need better qualifier checks: check mutated status for
- // Decl(e.g. was it assigned, passed as nonconst argument, etc)
- // FIXME: check if parameter will be a non l-value reference.
- // FIXME: We don't want to always pass variables of types like int,
- // pointers, etc by reference.
----------------
ArcsinX wrote:
> Yes, this patch's scope is to change non-const ref to const ref where
> possible. Passing by value is planned for an extra patch. And while the above
> example looks weird, it is correct, as the pointer value is not modified.
Yes, it's correct, I'm just saying that we need to return this FIXME back,
because it's still not addressed
https://github.com/llvm/llvm-project/pull/225666
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
