https://github.com/ojhunt requested changes to this pull request.

I'm not sure about this, the assertion failure is OMP specific but nothing in 
this PR seems to be OMP related. The guards on the early return feel very much 
like ad-hoc conditions to constrain that early return to the construct in the 
testcase.

I suspect that this PR is actually just papering over a symptom (the assertion 
failure) rather than addressing the cause of that symptom. e.g. an assertion 
failure is not a bug, it is an indication that a bug occurred earlier.

https://github.com/llvm/llvm-project/pull/226805
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to