https://github.com/aobolensk created https://github.com/llvm/llvm-project/pull/228404
None >From dddf123f75f1267acaccb066a0059e7d608af9b2 Mon Sep 17 00:00:00 2001 From: Arseniy Obolenskiy <[email protected]> Date: Fri, 2 Oct 2026 13:39:08 +0200 Subject: [PATCH] [CIR][AMDGPU] Drop stale logb FIXME in amdgcnspirv-builtins.hip (NFC) --- clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip b/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip index 015d4e57a2e29..dd92cfab285f1 100644 --- a/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip +++ b/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip @@ -76,13 +76,11 @@ __device__ float test_logb(float x) { // CIR-LABEL: cir.func no_inline @_Z9test_logbf // CIR: cir.call_llvm_intrinsic "frexp" %{{.*}} : (!cir.float) -> !rec_anon_struct -// FIXME: CIR emits 'add' without 'nsw' and 'fcmp une' instead of 'fcmp one'. - // LLVM-LABEL: define spir_func noundef float @_Z9test_logbf // LLVM: call{{.*}} @llvm.frexp.f32.i32 -// LLVM: add i32 %{{.*}}, -1 +// LLVM: add nsw i32 %{{.*}}, -1 // LLVM: call addrspace(4) float @llvm.fabs.f32 -// LLVM: fcmp une float %{{.*}}, +inf +// LLVM: fcmp one float %{{.*}}, +inf // OGCG-LABEL: define spir_func noundef float @_Z9test_logbf // OGCG: call{{.*}} @llvm.frexp.f32.i32 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
