keepyixiao wrote: > @keepyixiao btw, please do not rebase once you've pushed a PR up for review > (https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes), > that makes it much harder for reviewers to check out old comments and the > history of the PR as it's changed over time. Better to use a merge to catch > the PR up to the main branch.
Thanks for pointing this out! I wasn't aware of this guideline. I'll avoid rebasing/force-pushing PR branches during review in the future. https://github.com/llvm/llvm-project/pull/223124 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
