banach-space wrote: Hey @xlauko, thank you for implementing this!
There are a lot of patches in this stack, and the relationship between them is not immediately clear. IIUC, you are trying to de-duplicate some code? Strong +1 from me, but IMHO this calls for either an RFC or an umbrella GitHub issue to better communicate and advertise this design direction. Also: * I am under the impression that some patches in this stack are actually independent? * Please consider the review traffic and reducing the number of active PRs. With this many patches open at once, it is hard to tell what to prioritise. I also tend to de-prioritise long PR queues from individual contributors, mostly to make sure that I distribute my review bandwidth fairly across other contributors and PRs. * I'm not 100% sure that a generic `CodeGenUtils.cpp` file is the best approach. Ultimately, folks working on AMD GPU will not care about, e.g., Neon builtins, and vice versa. I'd be tempted to keep target-specific utilities separate and use `CodeGenUtils.cpp` only for hooks shared across targets. Thanks again for working on this! https://github.com/llvm/llvm-project/pull/227256 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
