================
@@ -1116,6 +1157,10 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
     } else {
       MPM.addPass(PB.buildPerModuleDefaultPipeline(Level));
     }
+  } else if (TargetTriple.isSPIRV() &&
----------------
maarquitos14 wrote:

I think getting passes when explicitly asking for none is worse than not having 
them by default, so I do see it as a downgrade: `-O2 -disable-llvm-passes` is 
the usual way to get unoptimized frontend IR at `-O2`. I agree that flipping 
the default is a bigger change, so in the meantime we could get away with 
something simpler: add a new flag (e.g. `-famdgcnspirv-size-opt`), and have the 
new `else if` trigger only when that flag is explicitly passed (still only for 
this target at O2 and above). The current default stays as it is, and users who 
want smaller binaries can opt in until we flip the default properly. Would that 
work?

https://github.com/llvm/llvm-project/pull/228188
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to