sammccall added inline comments.
================ Comment at: clangd/JSONRPCDispatcher.h:47 + // Whether output should be pretty-printed. + const bool Pretty; + ---------------- ioeric wrote: > It seems that we are piggybacking a state of clangd with `JSONOutput`. It > might make sense to store the option in clangd (or the dispatcher?) and pass > it via `writeMessage`, but what you have is also fine if it saves trouble :) Yeah, this isn't great. In the short term I don't think it does much harm. Longer-term we'll revisit logging organization as part of RequestContext that Ilya's working on. https://reviews.llvm.org/D40406 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
