https://github.com/Sirraide commented:
> Unlike declaration attributes, this path does not go through > `checkCommonAttributeFeatures` This seems very odd to me; I feel like we should just be calling that for type attributes as well. I've had an LLM track down and examine the original review that introduced `checkCommonAttributeFeatures()` (https://reviews.llvm.org/D114439), and there doesn't seem to be a reason why types are excluded. That said, I haven't actually read through the entire review myself because it's... quite long. If there is no reason, then I think the right fix would be to just call that function in the type attribute handling code before we ever get to the place where `swift_attr` is handled. @erichkeane Do you happen to know if there's a reason why we don't call `checkCommonAttributeFeatures()` on type attributes? https://github.com/llvm/llvm-project/pull/228873 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
