llvmorg-github-actions[bot] wrote:

<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: ʟᴜɴᴇx (im-lunex)

<details>
<summary>Changes</summary>

### Context &amp; Root Cause

* **The Problem:** The test added in `#<!-- -->224680` unconditionally expected 
diagnostics for `__ptr32` pointers. 
* **The Architecture Conflict:** On 32-bit targets (such as the 
`clang-armv7-2stage` buildbot), `__ptr32` maps to the native pointer size and 
**does not** receive a non-default address space. 
* **The Failure:** Because the non-default address space isn't assigned on 
32-bit targets, the expected diagnostic errors did not appear, causing the test 
suite to fail on non-64-bit architectures.

PR title and description assisted by Google **Gemini**.

---
Full diff: https://github.com/llvm/llvm-project/pull/229996.diff


1 Files Affected:

- (modified) clang/test/Sema/throw-address-space.cpp (+1-1) 


``````````diff
diff --git a/clang/test/Sema/throw-address-space.cpp 
b/clang/test/Sema/throw-address-space.cpp
index 0f085d13ae0cb..623a0b029455b 100644
--- a/clang/test/Sema/throw-address-space.cpp
+++ b/clang/test/Sema/throw-address-space.cpp
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -fsyntax-only -fcxx-exceptions -fexceptions -fms-extensions 
-verify %s
+// RUN: %clang_cc1 -triple x86_64-pc-win32 -fsyntax-only -fcxx-exceptions 
-fexceptions -fms-extensions -verify %s
 
 // Test for issue (https://github.com/llvm/llvm-project/issues/222931).
 // Reject throwing/catching pointers and references whose pointee/referred type

``````````

</details>


https://github.com/llvm/llvm-project/pull/229996
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to