vgvassilev wrote:

> > Can we test how this deduplication logic behaves with header units? I 
> > believe the share the same code path but just to make sure this case is 
> > covered for standard c++ modules.
> 
> I can test this and let you know. Do you think it should be added as one of 
> the tests in this PR? Or it would be repetitive since the clang modules one 
> is already in

A test or two wouldn’t hurt. 

https://github.com/llvm/llvm-project/pull/209795
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to