ChenMiaoi wrote: While working on this patch, I noticed a pre-existing design issue: `VectorTypeLoc` should serve as a base class, similar to `MatrixTypeLoc`. From what I found, it looks like the original author was aware of this but left it unaddressed.
https://reviews.llvm.org/D72281 https://github.com/llvm/llvm-project/blob/82e2575e82838b5874df8e6a163eef1c704514af/clang/include/clang/AST/TypeLoc.h#L2120 The comment mentions “some reason.” Does anyone know what that refers to? I’d like to work on this, but since this patch focuses on diagnostics, would it be better to open a separate issue and PR for the refactoring? https://github.com/llvm/llvm-project/pull/229328 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
