benhamilton added a comment.

Thanks, looks good. Just one question about the test.



================
Comment at: test/clang-tidy/objc-avoid-spinlock.m:4
+typedef int OSSpinLock;
+void OSSpinlockTry(OSSpinLock *__lock) {}
+
----------------
Not sure why you declared (and defined?) this one but not the others.

Either declare them all (no definition needed) or don't..



https://reviews.llvm.org/D40325



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to