https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/232179
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa<T>, cast<T> and the llvm::dyn_cast<T>
Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast.
Note that loadAPINotes() returns false only after storing a nonnull
APINotesReader * in Readers[*Dir].
Assisted-by: Antigravity
>From fa112a87f6f63a9ae15ebf7e02dc3bda4b42b48b Mon Sep 17 00:00:00 2001
From: Kazu Hirata <[email protected]>
Date: Mon, 5 Oct 2026 01:09:25 -0700
Subject: [PATCH] [clang] Migrate away from PointerUnion::dyn_cast (NFC)
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa<T>, cast<T> and the llvm::dyn_cast<T>
Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast.
Note that loadAPINotes() returns false only after storing a nonnull
APINotesReader * in Readers[*Dir].
Assisted-by: Antigravity
---
clang/lib/APINotes/APINotesManager.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/lib/APINotes/APINotesManager.cpp
b/clang/lib/APINotes/APINotesManager.cpp
index 2cc801d5415b84..5c1bb41d804e99 100644
--- a/clang/lib/APINotes/APINotesManager.cpp
+++ b/clang/lib/APINotes/APINotesManager.cpp
@@ -444,7 +444,7 @@ APINotesManager::findAPINotes(SourceLocation Loc) {
if (auto APINotesFile = FileMgr.getOptionalFileRef(APINotesPath)) {
if (!loadAPINotes(*Dir, *APINotesFile)) {
++NumHeaderAPINotes;
- if (auto Reader = Readers[*Dir].dyn_cast<APINotesReader *>())
+ if (auto Reader = dyn_cast<APINotesReader *>(Readers[*Dir]))
Results.push_back(Reader);
break;
}
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
