chaitanyav wrote: @AaronBallman The 25 commits are the existing history showing up as new after I rebased and force-pushed. Since your approval I made small changes:
- Addressed the open conversations I'd missed (such as adding the 'l' modifier to denote least types). - Moved the base-alignment lookup into one helper shared by `__builtin_assume_aligned` and the `stdc_load8_*` builtins in the bytecode interpreter. - Simplified the byte assembly in both constant evaluators (no behavior change). - Added a few more tests. <details> <summary>Commit Dates</summary> ``` 1 2026-06-09T12:50 [clang] Implement C2y stdc_load8_* endian-aware 8-bit load functions 2 2026-06-25T10:43 Use uint_least*_t/int_least*_t for stdc_load8_* return types 3 2026-06-25T17:00 Address review feedback for stdc_load8_* implementation 4 2026-06-25T19:36 Add tests for invalid pointer type argument 5 2026-06-25T20:19 Remove CHAR_BIT == 8 asserts from both interpreters 6 2026-06-25T20:43 Add test for null pointer type 7 2026-06-26T09:16 Reject unaligned pointers in stdc_load8_aligned_* at constexpr 8 2026-07-13T09:24 Add tests for stdc_load8_aligned_* and widen CodeGen coverage 9 2026-07-13T11:27 Fix incorrect offset in stdc_load8_aligned_* alignment check for struct fields 10 2026-07-13T12:13 Update ReleaseNotes with function suffixes 11 2026-07-13T12:49 Avoid repeating the attributes and prototypes across function spellings 12 2026-07-13T15:52 Avoid indexing into scalar pointer 13 2026-07-14T13:45 Extract getBaseAlignment function into ExprConstShared for sharing 14 2026-08-28T13:01 Fix crash in stdc_load8_* bytecode interpreter for string literals 15 2026-08-28T14:04 Use getElemType in stdc_load8_* 16 2026-09-08T09:44 Address codereview comments 17 2026-09-15T18:40 Use Pointer::computeLayoutOffset() instead of converting Ptr to APValue 18 2026-09-15T20:16 Preserve alignment instead of dropping down to 1-byte alignment 19 2026-09-15T21:11 Add CodeGen test coverage for the remaining stdc_load8_* variants 20 2026-10-07T13:25 Reject vla pointers and clean up scalar byte reads 21 2026-10-09T17:10 Update ReleaseNotes 22 2026-10-09T18:43 Fix crash in stdc_load8_* bytecode interpreter for unsupported pointees 23 2026-10-13T20:09 Add 'l' modifier to denote least types 24 2026-10-14T08:51 Reuse the getBaseAlignment() code in InterpBuiltin.cpp 25 2026-10-16T11:57 Simplify byte assembly in stdc_load8_* evaluators ``` </details> https://github.com/llvm/llvm-project/pull/203666 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
