ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land.
lgtm ================ Comment at: clangd/Protocol.cpp:56 + assert(*this && "Must check this is an object before calling parse()"); + if (const json::Expr *E = O->get(Prop)) { + return parse(*E, Out); ---------------- nit: no braces around one liners. ================ Comment at: clangd/Protocol.cpp:101 + static bool parse(const json::Expr &E, llvm::Optional<T> &Out) { + if (E.asNull()) + return true; ---------------- Should we set `Out` to `None` in this case? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40564 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits