================
@@ -4989,8 +4989,8 @@ CFGBlock
*CFGBuilder::VisitCXXForRangeStmt(CXXForRangeStmt *S) {
// Add the initialization statements.
Block = createBlock();
- addStmt(S->getBeginStmt());
addStmt(S->getEndStmt());
+ addStmt(S->getBeginStmt());
----------------
steakhal wrote:
So llvm used Phabricator at the time. It wasn't enforced.
There was a mailing list as well, where all the commits were reflected:
- https://lists.llvm.org/pipermail/cfe-commits/
- The relevant part is here:
https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160314/subject.html
with `r263895`. Sun Mar 20 05:33:40 2016
- Funnily, as it landed, people
[reported](https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160314/153248.html)
broken build bots.
There is no reliable search in the phabricator reviews unfortunately, so it's a
hit and miss if google has indexed it or not. Usually you can google
`site:reviews.llvm.org <term>`, but in this case it's not useful.
I probed https://reviews.llvm.org/D17103 (Feb 10 2016, 2:40 PM) ...
https://reviews.llvm.org/D19200 (Apr 17 2016, 12:31 PM).
It's pretty unlikely that if that change had a review, then it was opened
before Feb 10 2016. This suggests that there wasn't any review of this change,
thus no public discussion either.
https://github.com/llvm/llvm-project/pull/234467
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
