srividya-sundaram wrote:

> > > > One device compile per IGCA target needs IGCA targets as an OffloadArch 
> > > > (#227468), so I'll do it in a follow-up on top of that.
> > > 
> > > 
> > > Is it possible to add IGCA targets support to `--offload-arch` first and 
> > > rebase this PR?
> > 
> > 
> > This PR and #227468 don't depend on each other, so they can land in either 
> > order. Once both land, I'll create a new PR that maps device names to IGCA 
> > targets --> one device compile per IGCA target (labeled igca_*), with the 
> > driver passing the device list to ocloc. Is that okay? If you'd still 
> > prefer #227468 to land first, that's fine with me.
> 
> It's okay. I hoped that it's less work to add support for IGCA targets first 
> and implement xe-* targets on top of it.

 Thanks,  I've addressed the remaining comments. Could you take a final look ?

https://github.com/llvm/llvm-project/pull/229247
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to