ChenMiaoi wrote: Thanks for your work! LGTM, but this still needs approval from someone with commit access.
Btw, I noticed that you seem to have force-pushed. In LLVM, you can add as many commits as needed within a PR, but please be careful with force pushes and rebases during review (merge is preferred over rebase if have merge conflict), since they rewrite the change history. LLVM PRs are ultimately squash-merged. You can read more in the [LLVM GitHub User Guide](https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes). https://github.com/llvm/llvm-project/pull/230599 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
