mstorsjo wrote: > > `-mlong-double-80` is made default to fix the interoperability bug with > > x86_64-w64-mingw32. This also introduces an ABI break with old ARM64EC > > binaries. > > I think this need a RFC.
I think that's a bit overkill. The ecosystem of active mingw developers isn't very big (and those who are interested in arm64ec is even smaller), and all of them are already CCd on this PR. As a high level idea, I think making specifically the mingw variant of arm64ec use 80 bit long doubles to make it more compatible with x86_64 mingw (which indeed is the main target it needs to be consistent and compatible with), is very reasonable to do. The current state is indeed inconsistent, even though the problem is practically not very big. Whether it makes sense to do this mainly boils down to whether the implementation is sane, reasonable and acceptable - or if the current inconsistency is less of a burden than very messy code. (I haven't had time to actually review it in detail yet.) If people switch to 64 bit long doubles on x86_64 mingw and consistently on arm64ec mingw with `-mlong-double-64`, I would expect that to still work and still stay compatible as well. https://github.com/llvm/llvm-project/pull/237057 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
