================ @@ -1414,6 +1396,7 @@ documentation](CIR/index.md) for more information regarding ClangIR's status and ### Static Analyzer #### Crash and bug fixes +- Correctly model `mtx_timedlock` as 2-parameter function in the ``unix.BlockInCriticalSection`` checker. ---------------- steakhal wrote:
I think if we mention this fix in the release notes, then "correctly model" isn't really helpful for the user determining if they were impacted. We could go more specific, Was there an open GH issue about this? If yes, we should mention that as a suffix. Otherwise I think it's useful to link to the PR itself. The idea is that if we deemed something important enough to mention in the release notes, then we should have a link to some relevant place. Usually GH issues serve as a point of interest that implicitly has a link to the fix PR, thus it's enough to link to a GH issue form the notes. However, if there wasn't any (like probably in this case) then we should just link to this PR. https://github.com/llvm/llvm-project/pull/237154 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
