https://github.com/steffenlarsen commented:

I think this look reasonable. I'll run a few tests behind the scenes for good 
measure.

That said, I would prefer that the title and description is changed to focus on 
the fixes rather than the tests. Migrating tests is good, but arguably the most 
important part of this patch is the fixes.

https://github.com/llvm/llvm-project/pull/237387
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to