================
@@ -3949,6 +3949,19 @@ static StringRef getCanonicalArchString(Compilation &C,
         return StringRef();
       }
     }
+  } else if (Triple.isSPIRV() && ArchStr.starts_with("igca")) {
+    if (Triple.getOS() == llvm::Triple::AMDHSA) {
+      C.getDriver().Diag(clang::diag::err_drv_offload_bad_gpu_arch)
+          << "HIP" << ArchStr;
----------------
tahonermann wrote:

@srividya-sundaram, I agree this would be a good change to make. This 
conversation is marked as resolved, but there doesn't seem to be a 
corresponding change. I'll unresolve it for now. If the intent is to address 
this in another PR, that is certainly fine.

https://github.com/llvm/llvm-project/pull/227468
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to