================
@@ -18,7 +18,7 @@
namespace llvm {
namespace omp {
struct Version {
- using value_type = unsigned;
+ using value_type = int;
----------------
kparzysz wrote:
> I'll add clang version verification before merging this (in a separate PR).
That turned out to be a bit more than I wanted to do. The most logical place to
emit a diagnostic was in the driver where the value of the version is set.
However, diagnostics emitted from clang driver are handled differently than
those emitted later. Specifically, a warning emitted from the driver would have
no option to suppress it.
I didn't want to add a warning that cannot be turned off, plus the warning
would remain a warning even with `-Werror`, so instead I decided to invert the
approach here and keep the version unsigned.
https://github.com/llvm/llvm-project/pull/236089
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
