================
@@ -76,22 +76,24 @@ static bool shouldGenerateNote(llvm::raw_string_ostream &os,
}
if (PrevV.getCount() > CurrV.getCount())
- os << "Reference count decremented.";
+ os << "Reference count decremented";
else
- os << "Reference count incremented.";
+ os << "Reference count incremented";
if (unsigned Count = CurrV.getCount())
- os << " The object now has a +" << Count << " retain count.";
+ os << "; the object now has a +" << Count << " retain count";
return true;
case RefVal::Released:
if (CurrV.getIvarAccessHistory() ==
RefVal::IvarAccessHistory::ReleasedAfterDirectAccess &&
CurrV.getIvarAccessHistory() != PrevV.getIvarAccessHistory()) {
- os << "Strong instance variable relinquished. ";
+ os << "Strong instance variable relinquished; o";
+ } else {
+ os << "O";
}
- os << "Object released.";
+ os << "bject released";
----------------
NagyDonat wrote:
Good job spotting this!
As the string fragment `"bject released"` is very short, I'd prefer duplicating
it between the `if` and `else` branch (I think it won't make the line too long
even in the `if` branch).
That would also help those who `grep` "Object released" or "object released" in
the source code.
https://github.com/llvm/llvm-project/pull/237410
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
