cor3ntin wrote: @benlangmuir In the future, feel free to ping weekly.
However, a discussion was happening and it should not have been merged until that was resolved - especially given that both you and @akyrtzi appear to work at the same company, You ought to give the time for community concerns to be resolved before merging. Here in particular @ChenMiaoi was pointing out that the description of the PR - and therefore the motivation for the change is rather lackluster. This is exacerbated by the fact that there are no new test motivating the change. I suggest we continue post-commit review here and I hope you can address the feedback in a new PR. https://github.com/llvm/llvm-project/pull/200464 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
