AdityaSinha149 wrote:

> Is the enum abstraction more readable?
> 
> One alternative thing we could do is collapse the if statements with the same 
> return into one statement, example:
> 
> ```
>   if (FilesType == "i" || FilesType == "ii" ||
>       FilesType == "cui" || FilesType == "hipi")
>     return std::make_unique<TextFileHandler>("//");
> ```

makes sense, did the change. Please rereview.

https://github.com/llvm/llvm-project/pull/238231
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to