JonasToth created this revision. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai, klimek.
A user of the check opened a bugreport and reported that `std::exchange` triggers a false positive. I adjusted the doc to include a list of known (std) constructs that do trigger the issue with templates forgetting the type alias. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40829 Files: docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst Index: docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst =================================================================== --- docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst +++ docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst @@ -111,7 +111,11 @@ In template functions and classes, like in the example below, the information of the type aliases gets lost. Therefore using ``gsl::owner<T*>`` in a heavy templated code base might lead to false positives. -This limitation results in ``std::vector<gsl::owner<T*>>`` not being diagnosed correctly. + +Known code constructs that do not get diagnosed correctly are + +- ``std::exchange`` +- ``std::vector<gsl::owner<T*>>`` .. code-block:: c++
Index: docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst =================================================================== --- docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst +++ docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst @@ -111,7 +111,11 @@ In template functions and classes, like in the example below, the information of the type aliases gets lost. Therefore using ``gsl::owner<T*>`` in a heavy templated code base might lead to false positives. -This limitation results in ``std::vector<gsl::owner<T*>>`` not being diagnosed correctly. + +Known code constructs that do not get diagnosed correctly are + +- ``std::exchange`` +- ``std::vector<gsl::owner<T*>>`` .. code-block:: c++
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
