ioeric accepted this revision. ioeric added a comment. lg
================ Comment at: unittests/clangd/Matchers.h:54 + bool MatchAndExplain(const std::vector<T> &V, + ::testing::MatchResultListener *L) const { + std::vector<int> Matches(Matchers.size()); ---------------- `override`? ================ Comment at: unittests/clangd/Matchers.h:77 + +template <typename... M> class PolySubsequenceMatcher { + std::tuple<M...> Matchers; ---------------- It would be helpful to provide a bit documentation here. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40952 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits