faisalv added inline comments.
================
Comment at: lib/Parse/ParseExpr.cpp:223
ExprResult Parser::ParseConstraintExpression() {
- // FIXME: this may erroneously consume a function-body as the braced
- // initializer list of a compound literal
- //
- // FIXME: this may erroneously consume a parenthesized rvalue reference
- // declarator as a parenthesized address-of-label expression
- ExprResult LHS(ParseCastExpression(/*isUnaryExpression=*/false));
- ExprResult Res(ParseRHSOfBinaryExpression(LHS, prec::LogicalOr));
-
+ ExprResult Res(ParseExpression());
+ if (Res.isUsable() && !Actions.CheckConstraintExpression(Res.get())) {
----------------
Are you sure this only accepts logical-or-epxressions? Unlike Hubert's initial
implementation here, this seems to parse any expression (i.e including
unparenthesized commas and assignments)? What am I missing?
Repository:
rC Clang
https://reviews.llvm.org/D41217
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
