sammccall added inline comments.
================
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:45
+ IndexOpts.SystemSymbolFilter =
+ index::IndexingOptions::SystemSymbolFilterKind::All;
+ IndexOpts.IndexFunctionLocals = false;
----------------
hokein wrote:
> sammccall wrote:
> > out of curiosity, what does this do?
> No official document on this :(
> IIUC, this is a filter option to control whether we get symbols from the
> system code (like std library). `All` means we index all of them.
Ah, that sounds fine. Later we may actually want to index stdlib separately.
================
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:57
+
+static cl::OptionCategory GlobalSymbolCategory("global-symbol-builder
options");
+
----------------
(remove this and use GeneralCategory as default?)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41491
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
