sammccall added a comment. This is basically all plumbing, so I've marked the two lines that actually do something :-)
================ Comment at: lib/Sema/SemaLookup.cpp:3517 // Ensure all external identifiers are in the identifier table. - if (IdentifierInfoLookup *External = Idents.getExternalIdentifierLookup()) { - std::unique_ptr<IdentifierIterator> Iter(External->getIdentifiers()); - for (StringRef Name = Iter->Next(); !Name.empty(); Name = Iter->Next()) - Idents.get(Name); - } + if (Load) + if (IdentifierInfoLookup *External = Idents.getExternalIdentifierLookup()) { ---------------- here's a substantive change ================ Comment at: lib/Sema/SemaLookup.cpp:3546 + for (DeclContextLookupResult R : + Load ? Ctx->lookups() : Ctx->noload_lookups()) { for (auto *D : R) { ---------------- here's a substantive change Repository: rC Clang https://reviews.llvm.org/D41989 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits