JonasToth added a comment. In https://reviews.llvm.org/D41648#976665, @aaron.ballman wrote:
> My gut reaction is still that this check is going to be too chatty on real > world code bases to be of value beyond compliance with the C++ Core > Guidelines, but that's also sufficient enough reason to have the check in the > first place. Perhaps a reasonable approach would be to put in the heuristics > you think make the most sense, then run the check over some large real world > C++ code bases to see how many diagnostics are generated. That will also help > you to see code patterns to modify your heuristic until you're happy with the > results. Then we can debate whether there's more left to do from the data. Agreed. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
