george.karpenkov added inline comments.
================ Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:514 + QualType Ty = FD->getType(); + if (const FunctionProtoType *ProtoType = Ty->getAs<FunctionProtoType>()) + if (!ProtoType->isNothrow(getContext())) ---------------- auto? ================ Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:516 + if (!ProtoType->isNothrow(getContext())) + State = State->assume(RetVal.castAs<DefinedOrUnknownSVal>(), true); + } ---------------- This is neither here nor there, but for this and many other cases I think we could be considerably more readable by defining helpers `State->assumeIsTrue` and `State->assumeIsFalse` (or `assumeNonNull`, or whatever is most descriptive) Repository: rC Clang https://reviews.llvm.org/D42192 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
