lebedev.ri added inline comments.
================ Comment at: include/clang/ASTMatchers/ASTMatchers.h:5904 + return F->hasTrailingReturn(); + return false; +} ---------------- juliehockett wrote: > lebedev.ri wrote: > > There are no negative tests in the unittest that cover this false path. > Is there a test case you would recommend? I'm not entirely sure what would be > appropriate -- the tests compile in C++, yes? So `void f();` would just be a > normal function declaration (with a prototype, please correct me if I'm > wrong). I'd start by checking what @aaron.ballman has suggested: ``` EXPECT_TRUE(notMatches("void f();")); ``` https://reviews.llvm.org/D42273 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits